Skip to content

Add zizmor checks and fix all lints#2246

Open
ocefpaf wants to merge 8 commits into
python-visualization:mainfrom
ocefpaf:zizmor
Open

Add zizmor checks and fix all lints#2246
ocefpaf wants to merge 8 commits into
python-visualization:mainfrom
ocefpaf:zizmor

Conversation

@ocefpaf

@ocefpaf ocefpaf commented Jul 13, 2026

Copy link
Copy Markdown
Member

@hansthen I'll prepare the PR to fetch the supporting data from a release afte this one. I had this sitting on my laptop for a long time.

@ocefpaf ocefpaf marked this pull request as draft July 13, 2026 22:03
@ocefpaf

ocefpaf commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

We need to either find another source for the WMS time plugin or we need to remove it from the docs. The source we are using there is failing and prevent us from building the docs.

    ConnectTimeout: HTTPSConnectionPool(host='pae-paha.pacioos.hawaii.edu', port=443): Max retries exceeded with url: /thredds/wms/dhw_5km?service=WMS&request=GetCapabilities&version=1.1.1 (Caused by ConnectTimeoutError(<HTTPSConnection(host='pae-paha.pacioos.hawaii.edu', port=443) at 0x7ff7942367b0>, 'Connection to pae-paha.pacioos.hawaii.edu timed out. (connect timeout=100)'))

@hansthen are you OK with removing this part of the docs?

@ocefpaf ocefpaf marked this pull request as ready for review July 13, 2026 22:32
@hansthen

hansthen commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

@hansthen are you OK with removing this part of the docs?
Yes. Do you want me to remove it in a separate PR or will you make it part of this one?

@ocefpaf

ocefpaf commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

Yes. Do you want me to remove it in a separate PR or will you make it part of this one?

I can do it after this one. I'm still looking for alternatives and/or keeping some parts of the example alive without reaching the URL. More on that soon.

Let me know if you are OK with this PR and I'll tackle the docs+downloadable assets right after.


steps:
- uses: actions/checkout@v7
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required? I take it the long string is a version hash? What will this mean for future maintenance?

@hansthen

Copy link
Copy Markdown
Collaborator

Yes. Do you want me to remove it in a separate PR or will you make it part of this one?

I can do it after this one. I'm still looking for alternatives and/or keeping some parts of the example alive without reaching the URL. More on that soon.

Let me know if you are OK with this PR and I'll tackle the docs+downloadable assets right after.

I'm okay with it. I just had one question (why the long version hashes are required).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants