Remove conditionally-compiled debug C code - #9915
Open
akx wants to merge 6 commits into
Open
Conversation
NDEBUG is "not debug"; the debug checks were _enabled_ when it was set
akx
marked this pull request as ready for review
August 27, 2026 13:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at
Mode.cand noticed 0567f06 had gotten the semantics ofNDEBUGwrong;NDEBUGis true when not debugging, so these checks were running all the time in release builds. That said, those checks weren't really necessary anyway; we can see that all of the constantModeDatain that file has a non-NULL mode string. It's not worth testing at runtime.Following that, I took a look at other
#ifdef'd code to get rid of other debug-like code that was never compiled in... and on top of that, there's a fun commit that removes anexit(1);from an unlikely error branch ofQuant.c. I supposeQuant.cwas ported from some application code in 1998 and no one noticed all of theexit()s.