Skip to content

Remove unused C convert method - #9910

Merged
radarhere merged 2 commits into
python-pillow:mainfrom
radarhere:convert_function
Aug 27, 2026
Merged

Remove unused C convert method#9910
radarhere merged 2 commits into
python-pillow:mainfrom
radarhere:convert_function

Conversation

@radarhere

Copy link
Copy Markdown
Member

Part of #8389

radarhere and others added 2 commits August 27, 2026 19:04
Co-authored-by: Alexander Karpinsky <homm86@gmail.com>
Co-authored-by: Alexander Karpinsky <homm86@gmail.com>
@akx

akx commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

I was looking at this earlier too. Should we take the opportunity to also rename the functions/methods to something a little more descriptive?

@radarhere

Copy link
Copy Markdown
Member Author

You'd like to rename convert2? Ok, to what? convert_to_image?

Or, if you want, we could suggest combining it with new_block, and go for a single, clear convert_to_block.

@akx

akx commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

You'd like to rename convert2?

It isn't a great name, is it? 😅

Ok, to what? convert_to_image?

convert_into would be closer, maybe, since AIUI it converts self into the format of the caller-allocated im?

Or, if you want, we could suggest combining it with new_block, and go for a single, clear convert_to_block.

I'd maybe skip that, because you could maybe want to use convert_into with a new_arrow allocated image too?

EDIT: I had to look up what new_block does: it allocates an image in a single contiguous block (because that's what Tk needs).

@radarhere
radarhere merged commit eb3935f into python-pillow:main Aug 27, 2026
58 of 59 checks passed
@radarhere
radarhere deleted the convert_function branch August 27, 2026 11:04
@radarhere

Copy link
Copy Markdown
Member Author

I've created #9911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants