Use borrowed data when exporting an image created by Image.fromarrow - #9897
Open
lazerg wants to merge 2 commits into
Open
Use borrowed data when exporting an image created by Image.fromarrow#9897lazerg wants to merge 2 commits into
lazerg wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9896
An image created by
Image.fromarrow()borrows its data, soblockandblocksare both NULL and only the row pointers inimageare set.export_single_channel_array()andexport_fixed_pixel_array()fall back toblocks[0].ptrwhenblockis NULL, which dereferenced NULL and crashed onpa.array(im).A borrowed array is only accepted when its length matches the image, so the rows are contiguous and the export can start from the first one.