Remove or protect secrets in Actions#9544
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.15.4 → v0.15.9](astral-sh/ruff-pre-commit@v0.15.4...v0.15.9) - [github.com/psf/black-pre-commit-mirror: 26.1.0 → 26.3.1](psf/black-pre-commit-mirror@26.1.0...26.3.1) - [github.com/pre-commit/mirrors-clang-format: v22.1.0 → v22.1.2](pre-commit/mirrors-clang-format@v22.1.0...v22.1.2) - [github.com/python-jsonschema/check-jsonschema: 0.37.0 → 0.37.1](python-jsonschema/check-jsonschema@0.37.0...0.37.1) - [github.com/zizmorcore/zizmor-pre-commit: v1.22.0 → v1.23.1](zizmorcore/zizmor-pre-commit@v1.22.0...v1.23.1) - [github.com/tox-dev/pyproject-fmt: v2.16.2 → v2.21.0](tox-dev/pyproject-fmt@v2.16.2...v2.21.0)
for more information, see https://pre-commit.ci
|
Looking at the zizmor findings, all but one are like this for different I think we can remove the token. https://app.codecov.io/account/github/python-pillow/org-upload-token says a token is required ("When a token is required, your team must use a global or repo-specific token for uploads."). I've flipped that to not required ("When a token is not required, your team can upload coverage reports without one. Existing tokens will still work, and no action is needed for past uploads.) I'll remove the token and we can confirm if coverage continues to upload. |
|
Coverage looks okay, I see lines like this for all workflows:
|
|
I've asked for recommendations about https://discord.com/channels/786703927705862175/1257384941990318121/1492125224462975097 |
Is the simple solution not to just create an environment at https://github.com/python-pillow/Pillow/settings/environments and move the secret there? We could restrict it to the main branch. |
|
Simplest solution is to ignore the warning :) But yes, a branch-restricted env was suggested on the Discord server too. I'll set it up. |
|
updates: