Fix uniq comparisons across hashability paths#1514
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
Compare fallback values against values handled by the structural hash. Add regression coverage for both input orderings.
Member
|
Hi there -- such values aren't possible to encounter in JSON as far as I can tell from your patch. Is there some actual user-facing bug you see via this path (i.e. a schema)? If so we'd at least want to test via that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uniq()could report equal values as unique when one uses the structural-hash path and the other falls back to pairwise comparison (for example,setandfrozenset). Compare fallback values across both paths so the result no longer depends on input order.