Align theme toggle with system preference and react to prefers-color-scheme changes#186
Open
Copilot wants to merge 6 commits into
Open
Align theme toggle with system preference and react to prefers-color-scheme changes#186Copilot wants to merge 6 commits into
prefers-color-scheme changes#186Copilot wants to merge 6 commits into
Conversation
Copilot created this pull request from a session on behalf of
m-aciek
June 3, 2026 23:17
View session
Copilot
AI
changed the title
Align theme toggle with system preference and react to
Align theme toggle with system preference and remove redundant normalization helper
Jun 3, 2026
prefers-color-scheme changes
Copilot
AI
changed the title
Align theme toggle with system preference and remove redundant normalization helper
Refine theme toggle to use system preference by default and react to OS theme changes
Jun 3, 2026
Copilot
AI
changed the title
Refine theme toggle to use system preference by default and react to OS theme changes
Clarify theme-source semantics by renaming Jun 3, 2026
getPreferredTheme to getSystemTheme
getPreferredTheme to getSystemThemeprefers-color-scheme changes
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ed123f91a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Copilot stopped work on behalf of
m-aciek due to an error
June 4, 2026 00:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theme selection now treats browser/OS preference as the default mode instead of always persisting manual toggles. When a user-selected theme matches
prefers-color-scheme, the override is removed so future system changes are reflected automatically.Behavior model
stored theme(if different from system) winsToggle semantics
localStorage.themeis removed (return to system-following mode).Live system theme updates
matchMedia('(prefers-color-scheme: dark)')change listener.Reference: #174 (comment)
📊 Dashboard preview 📊: https://python-docs-translations.github.io/dashboard/186/merge/