Remove double newline at EOF of po files#1253
Open
CorentinDeBoisset wants to merge 1 commit intopython-babel:masterfrom
Open
Remove double newline at EOF of po files#1253CorentinDeBoisset wants to merge 1 commit intopython-babel:masterfrom
CorentinDeBoisset wants to merge 1 commit intopython-babel:masterfrom
Conversation
akx
reviewed
Apr 10, 2026
Comment on lines
+668
to
+680
| first_message = True | ||
|
|
||
| for message in _sort_messages(catalog, sort_by=sort_by): | ||
| if not message.id: # This is the header "message" | ||
| if omit_header: | ||
| continue | ||
| is_header = not message.id | ||
| if is_header and omit_header: | ||
| continue | ||
|
|
||
| if first_message: | ||
| first_message = False | ||
| else: | ||
| yield '\n' | ||
|
|
||
| if is_header: |
Member
There was a problem hiding this comment.
Would this become simpler (not sure if it would!) if first_message was instead something like emitted_messages (boolean or integer)? IOW, the if not message.id: if omit_header: continue check would be as is in the preimage, and then something like
if emitted_messages:
# Emit a separator between this and the previous message
yield '\n'
emitted_messages = True
?
Member
|
Thanks for the contribution! Please see the review comment; I'm not sure if it'd simplify things, but to me it looks like there's maybe more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello !
This is my first PR, so I'm not fully sure about everything. I used the unit tests to check for regressions, but are there other untested edge-cases we should worry about ?
Fixes #799