pathlib,assertion/rewrite: clean up some no longer needed code for importlib import mode#14379
Open
bluetech wants to merge 3 commits intopytest-dev:mainfrom
Open
pathlib,assertion/rewrite: clean up some no longer needed code for importlib import mode#14379bluetech wants to merge 3 commits intopytest-dev:mainfrom
importlib import mode#14379bluetech wants to merge 3 commits intopytest-dev:mainfrom
Conversation
There should not be a need to look at `module_path` in `find_spec`, only at the `module_location`, i.e. the parent path of the module. It's not needed for assertion rewrite (why would it? It's not supposed to be special in this regard). This was added in 28e1e25, seems that commit did the right thing by removing `module_path` in the general case, but for some reason kept it for the assertion rewrite meta path finder.
…spec` It is always `module_path.parent`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanups we can do after merging #12313. Please see #12313 (review) for context and the commits for details.