Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes compatibility with pytest mainline (and pytest >= 9) by ensuring rerunfailures properly resets fixture execution state when a fixture setup fails and is retried, preventing pytest’s internal assertion about leftover fixture finalizers.
Changes:
- Clear
FixtureDef._finalizerswhen removing cached results for failed fixtures so reruns can re-execute fixtures cleanly. - Document the compatibility fix in
CHANGES.rst.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/pytest_rerunfailures.py |
Clears fixture finalizers during failed-fixture cache cleanup to avoid pytest >= 9 assertion failures on rerun. |
CHANGES.rst |
Adds an unreleased changelog entry describing the compatibility fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323