Skip to content

fix: force trace core when dynamic contexts are requested #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aryansk wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: force trace core when dynamic contexts are requested #757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions src/pytest_cov/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ def __init__(self, options: argparse.Namespace, config: Union[None, object], nod
self.cov_append = options.cov_append
self.cov_branch = options.cov_branch
self.cov_precision = options.cov_precision
self.cov_context = getattr(options, 'cov_context', None)
self.config = config
self.nodeid = nodeid

Expand All @@ -72,6 +73,19 @@ def __init__(self, options: argparse.Namespace, config: Union[None, object], nod
self.is_collocated = None
self.started = False

@property
def _coverage_core(self):
"""Return the coverage core to use.

When dynamic contexts are requested (--cov-context=test),
force the ``trace`` core because ``sysmon`` (the default on
Python 3.14+) does not support them and coveragepy >= 7.15.3
emits a warning. (#755)
"""
if self.cov_context == 'test':
return 'trace'
return None

@contextlib.contextmanager
def ensure_topdir(self):
original_cwd = Path.cwd()
Expand Down Expand Up @@ -234,12 +248,15 @@ class Central(CovController):

@_ensure_topdir
def start(self):
self.cov = coverage.Coverage(
cov_kwargs = dict(
source=self.cov_source,
branch=self.cov_branch,
data_suffix=True,
config_file=self.cov_config,
)
if self._coverage_core is not None:
cov_kwargs['core'] = self._coverage_core
self.cov = coverage.Coverage(**cov_kwargs)
if self.cov.config.dynamic_context == 'test_function':
message = (
'Detected dynamic_context=test_function in coverage configuration. '
Expand Down Expand Up @@ -284,12 +301,15 @@ class DistMaster(CovController):

@_ensure_topdir
def start(self):
self.cov = coverage.Coverage(
cov_kwargs = dict(
source=self.cov_source,
branch=self.cov_branch,
data_suffix=True,
config_file=self.cov_config,
)
if self._coverage_core is not None:
cov_kwargs['core'] = self._coverage_core
self.cov = coverage.Coverage(**cov_kwargs)
if self.cov.config.dynamic_context == 'test_function':
raise DistCovError(
'Detected dynamic_context=test_function in coverage configuration. '
Expand Down Expand Up @@ -387,12 +407,15 @@ def start(self):
self.cov_config = self.cov_config.replace(master_topdir, worker_topdir)

# Erase any previous data and start coverage.
self.cov = coverage.Coverage(
cov_kwargs = dict(
source=self.cov_source,
branch=self.cov_branch,
data_suffix=True,
config_file=self.cov_config,
)
if self._coverage_core is not None:
cov_kwargs['core'] = self._coverage_core
self.cov = coverage.Coverage(**cov_kwargs)
# Prevent workers from issuing module-not-measured type of warnings (expected for a workers to not have coverage in all the files).
self.cov._warn_unimported_source = False
self.cov.start()
Expand Down