Skip to content

Make Stable ABI optional #161

Description

@karosc

as of right now, the package compiles stable ABI by default. This has caused some problems for a few users downstream who compile the library as part of their own distributions. I propose we make stable ABI opt-in using an environment var or cmake flag rather than opt-out as it currently is.

This should be a modest change in three files:

  1. update swmm-toolkit/CMakeLists.txt
  2. update pyproject.toml
  3. update build env vars to target stable ABI

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions