Dual login buttons: one-click IdP login via kc_idp_hint - #63
Open
thusser wants to merge 1 commit into
Open
Conversation
- PYOBS_AUTH['IDP_HINT']/['IDP_LABEL'] (static config, like the rest of the block); context processor exposes keycloak_idp_hint/keycloak_idp_label - Login template renders the hinted IdP button + a local-Keycloak-account button when a hint is configured, the plain single button otherwise (both gated on keycloak_login_enabled) - urlencode the existing unescaped ?next= on the Keycloak link (pre-existing) - Pin pyobs-auth>=2.0.0.dev8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements section 2 of
specs/plans/2026-08-21-keycloak-idp-hint-login.md(pyobs-core): dual login buttons on the login page — one click straight to the GWDG (or other) IdP SSO page, while keeping the local-Keycloak-account path reachable.Changes
PYOBS_AUTH['IDP_HINT']/['IDP_LABEL'](env-drivenKEYCLOAK_IDP_HINT/KEYCLOAK_IDP_LABEL).keycloak_idp_hint/keycloak_idp_labelnext tokeycloak_login_enabled.next:?idp_hint=&next=...);keycloak_login_enabled, soIDP_HINTwithoutSERVER_URL(Keycloak disabled) renders no buttons instead of dead links.?next={{ next }}on the Keycloak link (|urlencode) while touching the file..env.example+ README document the new vars;pyobs-authpin bumped to>=2.0.0.dev8.Verification
Dependency
Depends on pyobs-auth v2.0.0.dev8 (pyobs/pyobs-auth#8): merge that PR and push tag
v2.0.0.dev8(publishes to PyPI viapypi.yml) before this one's CI can resolve the bumped pin. The feature itself is inert until then — the?idp_hint=param is only honored by the new pyobs-auth.