Simulator support for FLOAT64 type. - #3002
Merged
Merged
Conversation
pkubanek
force-pushed
the
fix/float64-simulator
branch
23 times, most recently
from
August 20, 2026 23:43
79ce557 to
a482605
Compare
janiversen
requested changes
Aug 21, 2026
janiversen
left a comment
janiversen
left a comment
Collaborator
There was a problem hiding this comment.
The changes are ok, but CI (ubuntu 3.14) tells me that coverage have dropped to 98%, this is due to test missing for a single line:
please correct that.
Collaborator
|
You can test on your local branch with "pytest --cov". |
pkubanek
force-pushed
the
fix/float64-simulator
branch
from
August 21, 2026 10:13
c6f7308 to
f0aaa72
Compare
pkubanek
force-pushed
the
fix/float64-simulator
branch
from
August 21, 2026 10:18
f0aaa72 to
acb1b7c
Compare
Contributor
Author
|
Coverage fixed - I added tests for all supported CellType types and implemented methods. |
Collaborator
|
Looking forward to see the INT64 Pr, please do not forget pull the new dev and update your branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simulator handles FLOAT64 (8 byte float, double in C/Java/...) type. Refactored Simulator's CellType, changed setup.json.