fix: call callable action once per expand_action instead of multiple times - #487
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix: call callable action once per expand_action instead of multiple times#487AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
…times The action property invoked the callable on each access, so expand_action() called it up to three times (no-task path, list check, string format path). Cache the resolved value in a local variable to invoke it only once. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
AruneshDwivedi
force-pushed
the
fix-cmdaction-callable
branch
from
August 1, 2026 09:18
e9864c5 to
07b94f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
actionproperty on CmdAction invokes the callable on each access. Since expand_action() reads self.action up to three times, the callable was being executed up to three times per task run.Fix: resolve the action to a local variable at the start of expand_action() and reuse it.
Fixes #437