Restore -1 Zarr chunk sentinel handling#11291
Open
officialasishkumar wants to merge 1 commit intopydata:mainfrom
Open
Restore -1 Zarr chunk sentinel handling#11291officialasishkumar wants to merge 1 commit intopydata:mainfrom
officialasishkumar wants to merge 1 commit intopydata:mainfrom
Conversation
Translate xarray's documented -1 chunk sentinel into explicit full-dimension chunk sizes before passing chunk metadata to zarr, and cover the regression with a roundtrip test.
github-actions
bot
added
topic-backends
topic-zarr
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dataset.to_zarrandDataArray.to_zarrdocument-1as a way to request a full-dimension chunk in the encoding. With zarr v3, passing that sentinel through unchanged now fails because zarr requires non-negative chunk sizes.This normalizes
-1to the written dimension length before passing chunk metadata to zarr, preserving the documented behavior and the legacy zarr v2-compatible workflow.Checklist
whats-new.rstapi.rst(N/A - no new public API)AI Disclosure
Tools: Codex