Preserve coordinates after non-leading-dimension groupby reductions#11290
Open
officialasishkumar wants to merge 1 commit intopydata:mainfrom
Open
Preserve coordinates after non-leading-dimension groupby reductions#11290officialasishkumar wants to merge 1 commit intopydata:mainfrom
officialasishkumar wants to merge 1 commit intopydata:mainfrom
Conversation
Use the reordered variable sizes when deciding which coordinates survive _replace_maybe_drop_dims, and add regression coverage for both the internal helper and groupby behavior.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fallback
groupbyreductions can reorder variable dimensions beforeDataArray._replace_maybe_drop_dimsfilters coordinates. That path still zipped shapes against the original dimension order, which dropped unrelated coordinates when the reordered dimensions had different lengths.This switches that branch to use
variable.sizesand adds regression coverage for both the helper and the user-visiblegroupbybehavior.Checklist
whats-new.rstapi.rst(N/A - no new public API)AI Disclosure
Tools: Codex