Skip to content

DOCS: Clarify what mode means in docstring for to_zarr#11229

Merged
jsignell merged 3 commits intopydata:mainfrom
jsignell:mode-docstring
Apr 13, 2026
Merged

DOCS: Clarify what mode means in docstring for to_zarr#11229
jsignell merged 3 commits intopydata:mainfrom
jsignell:mode-docstring

Conversation

@jsignell
Copy link
Copy Markdown
Member

Closes #11159

@github-actions github-actions bot added the topic-DataTree Related to the implementation of a DataTree class label Mar 13, 2026
Copy link
Copy Markdown
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to add this to whats-new

Comment thread xarray/core/dataarray.py Outdated
@jsignell jsignell added the plan to merge Final call for comments label Apr 10, 2026
@jsignell jsignell merged commit 13dc9ab into pydata:main Apr 13, 2026
42 of 43 checks passed
@jsignell jsignell deleted the mode-docstring branch April 13, 2026 14:44
TomNicholas added a commit to earth-mover/icechunk that referenced this pull request Apr 13, 2026
Sync the mode parameter documentation with the upstream change
in pydata/xarray#11229.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-merge-queue bot pushed a commit to earth-mover/icechunk that referenced this pull request Apr 13, 2026
@ianhi 's bot was
[complaining](https://github.com/earth-mover/icechunk/actions/runs/24366022151/job/71157904552?pr=2049)
because xarray [modified](pydata/xarray#11229)
their `.to_zarr` docstring slightly - this updates ours to match.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jsignell added a commit to jsignell/xarray that referenced this pull request Apr 15, 2026
* Clarify what mode means in docstring for `to_zarr`
* Make docstring a real list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan to merge Final call for comments topic-DataTree Related to the implementation of a DataTree class

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overwriting zarr using mode='w' converts unmodified data to nan.

2 participants