Lower cffi version requirement from >=2.0.0 to >=1.16#14851
Open
frasertweedale wants to merge 1 commit into
Open
Lower cffi version requirement from >=2.0.0 to >=1.16#14851frasertweedale wants to merge 1 commit into
frasertweedale wants to merge 1 commit into
Conversation
Member
|
What's the motivation for this? Distros not having cffi 2.0 is not a sufficient motivation: mixing old deps with new ones is better solved by distros updating their cffis. Further, this now gives you the wrong behavior on free-threaded Pythons, where it permits you to install a cffi that doesn't support it. |
Require cffi >= 2.0.0 only for Python >= 3.13 (needed for free-threaded Python support). Allow cffi >= 1.16 for older Python, enabling use on distros that don't have cffi 2.0 yet.
frasertweedale
force-pushed
the
cffi-version-stepdown
branch
from
3918911 to
4860ae9
Compare
Contributor
Author
|
The motivation is: RHEL has old cffi for now, and it's one less thing to patch. |
Member
|
If RHEL wants to use a very recent cryptography, why can't you upgrade your cffi? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some distros don't have cffi >= 2.0.0 yet. v1.16 still works, so
reduce the lower bound.