Skip to content

fix(files): fetch the HLS manifest with the account download token - #185

Merged
altaywtf merged 3 commits into
mainfrom
fix/hls-download-token
Nov 21, 2026
Merged

altaywtf merged 3 commits into
mainfrom
fix/hls-download-token

Conversation

@altaywtf

@altaywtf altaywtf commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Summary

putio files hls-manifest now sends the account download token on the playlist request, not the OAuth token.

Request Before After
GET /v2/account/info?download_token=1 not sent OAuth token
GET /v2/files/{id}/hls/media.m3u8 OAuth token download token
Variant URIs in the manifest OAuth token, redacted download token, redacted
  • Bumps @putdotio/sdk to 17.0.0.
  • putio sdk call fetches the download token for media operations that omit downloadToken, so files.getHlsMasterPlaylist [id] keeps working.

Verification

Live on the test account via a logging proxy: this branch sends the download token (200), main the OAuth token. No token: 401.

Notes

Not verified: the standalone SEA binary.

The HLS master playlist is a media request, so it carries the account
download token, never the OAuth access token. @putdotio/sdk 17 makes
getHlsMasterPlaylist require it; `files hls-manifest` now reads it from
account info and passes it through. The `sdk` passthrough schema for
files.getHlsMasterPlaylist requires downloadToken to match.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T10:00:02.674828Z db46862 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d8bb0bed47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/internal/sdk-operation-args.ts Resolved
sdk call output redacts download_token, so callers had no way to pass
it. Keeps files.getHlsMasterPlaylist working with [id] as before.
@altaywtf
altaywtf merged commit 79500e7 into main Nov 21, 2026
6 checks passed
@altaywtf
altaywtf deleted the fix/hls-download-token branch November 21, 2026 10:01
putio-ci Bot added a commit that referenced this pull request Nov 21, 2026
## [1.10.7](v1.10.6...v1.10.7) (2026-11-21)

### Bug Fixes

* **files:** fetch the HLS manifest with the account download token ([#185](#185)) ([79500e7](79500e7))
@putio-ci

putio-ci Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.10.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@putio-ci putio-ci Bot added the released label Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant