fix: F-2026-18817 | [Dual Defense] SVM Log Truncation + Resolver No Success-Vote Starves Oldest-1000 Pending Queue - #318
Open
Aman035 wants to merge 8 commits into
Open
fix: F-2026-18817 | [Dual Defense] SVM Log Truncation + Resolver No Success-Vote Starves Oldest-1000 Pending Queue#318Aman035 wants to merge 8 commits into
Aman035 wants to merge 8 commits into
Conversation
…newer rows (F-2026-18817)
… default (F-2026-18817)
…osts latency not coverage (F-2026-18817)
…t and returns no next key (F-2026-18817)
…e whole poll (F-2026-18817)
…ansport limits (F-2026-18817)
…eeds one request (F-2026-18817)
… machinery (F-2026-18817)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-2026-18817 Pending outbound poll reads a single page
Issue
GetAllPendingOutboundsrequested oneLimit: 1000page and ignoredPagination. The query is oldest-first and not chain-scoped.Approach taken
Pagination.NextKeyinstead of reading one page.Also found while auditing the other list queries:
GetAllChainConfigssent noPageRequestat all, and the server usesquery.CollectionPaginate, which applies the SDK default of 100 when the request is nil. Chain configs past the 100th were silently dropped, and a chain missing from that list is simply never watched. Now paged.Left alone:
GetPendingTssEvents(PendingTssEventsis only written byInitiateTssKeyProcess, which rejects concurrent processes, so the set is 0 or 1).Not changed
The resolver still votes failure only; success observation stays with the event listener by design. A success vote derived from chain state cannot supply a deterministic
GasFeeUsed, and that value is part of the outbound ballot key, so validators would have to agree on somethingExecutedSubTxdoes not expose — it is existence-only. Making the success signal durable belongs on the emitting side, raised with the gateway team separately.Tests
NextKeyacross pages, asserting the cursor is threaded through rather than re-queried.Pagination.NextKey, always sends aPageRequest, propagates errors.Note for core
AllUniversalValidatorsandPendingFundMigrationsignore pagination entirely — theyWalkthe whole collection and return it. No truncation risk, but no bound either, so the response grows with the set until it hits the gRPC message limit and the query fails outright.AllUniversalValidatorsfeedsIsKnownPeer, the TSS admission gate from F-2026-18136. Worth moving both toCollectionPaginatelike their siblings; the client already walks pages.