Stop using apache::apache_version - #2552
Open
ekohl wants to merge 2 commits into
Open
Conversation
3 tasks
bastelfreak
approved these changes
Jun 7, 2024
Member
|
Hey @ekohl and @bastelfreak ... Found this old PR that got approved but never merged up. Do we think this could still be useful in the apache module? Or should we close this out? |
Collaborator
Author
|
Probably still a good cleanup because it simplifies the code and makes sure the tests actually run. |
Member
|
Alrighty! I will rebase, get it into the list for engineering, and kick off some acceptance testing just to see where we are at with the latest codebase. |
They missed the _spec suffix so they weren't executed. They're also simplified to stop setting the apache_version parameter since it's ignored anyway.
jst-cyr
force-pushed
the
fix-lbmethods
branch
from
September 4, 2026 17:21
4fbf14e to
b55b19d
Compare
Member
|
Reran the unit test CI and there are some failures, so I haven't kicked off the full acceptance testing. Those will need to be addressed first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cedd45b this was dropped and the whole module is now only for Apache 2.4+. This means the parameter is redundant. The parameter is kept in so this can be released in a bugfix release, but the next major version should drop it.
Fixes: cedd45b ("Drop Apache 2.2 support")