feat: Wave 3 — SC→REQ traceability, float helpers, orphan fixes#79
Open
feat: Wave 3 — SC→REQ traceability, float helpers, orphan fixes#79
Conversation
Traceability links: - Link all 19 system constraints to implementing requirements via constraint-satisfies (constraint-has-requirement: 0% → 100%) - Link all 24 controller constraints to implementing requirements via satisfies links - Fix REQ-2 orphan (link to DD-3, DD-6) - Fix CP-1/CP-2/CP-3 orphans (add acted-on-by controller links) Float canonicalization refactor: - Extract F32/F64_CANONICAL_NAN constants - Extract is_f32/f64_subnormal() and canonicalize_f32/f64() helpers - Replace inline checks across 8 arithmetic fold sites - Pure refactor, no behavioral change Trace: SC-1, REQ-1, REQ-2, H-1 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
Rust stable rolled to 1.95 on 2026-04-14, enabling stricter collapsible_match. Applied cargo clippy --fix — 57 sites converted from nested match + if body to match arm guards. No behavior change, purely syntactic. Files: - loom-core/src/verify.rs (36 fixes) - loom-core/src/lib.rs (12 fixes) - loom-core/src/stack.rs (3 fixes) - loom-core/src/fused_optimizer.rs (3 fixes) - loom-testing/src/emi/analysis.rs (2 fixes) - loom-testing/src/emi/mutation.rs (1 fix) Verified: cargo clippy --all-targets --all-features -- -D warnings clean; cargo test --release --lib --bins passes. Trace: REQ-18 (CI quality gates)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
F32_CANONICAL_NAN,canonicalize_f32(),is_f32_subnormal(), etc.). Pure refactor for auditability of H-1.4/H-1.5 mitigations.Rivet metrics (cumulative across all waves)
Test plan
rivet validate— 6 errors (safety-goal context, not blocking), 0 broken cross-refs🤖 Generated with Claude Code