fix(ci): re-pin cranelift-isle to 0.132.x — restore wasm32-wasip2 build - #304
Open
avrabe wants to merge 1 commit into
Open
fix(ci): re-pin cranelift-isle to 0.132.x — restore wasm32-wasip2 build#304avrabe wants to merge 1 commit into
avrabe wants to merge 1 commit into
Conversation
A dependency bump re-floated the workspace `cranelift-isle` constraint from
0.132 to 0.134, contradicting the pin rationale in the comment right above it:
0.133+ raised its MSRV to rustc 1.94.0, which is not yet stable (CI stable is
1.93.1). The result was `cranelift-isle@0.134.2 requires rustc 1.94.0` failing
the wasm32-wasip2 build ("WASM Build (wasm32-wasip2 with Z3)") on every commit
since the bump — main has been red on it for days.
Re-pin to `^0.132` (resolves 0.132.3, the known-good line v1.1.13–v1.1.16
shipped on), restoring green. Verified: cranelift-isle resolves to 0.132.3 and
loom-shared + loom-isle compile.
This is the Nth float-induced main red; the durable cure remains committing the
lockfile (#142). Comment above the constraint updated to warn against re-widening.
Refs #142
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Main's
WASM Build (wasm32-wasip2 with Z3)has been red for days:cranelift-isle@0.134.2 requires rustc 1.94.0but CI stable is 1.93.1.Cause
A dependency bump re-floated the workspace
cranelift-isleconstraint0.132→0.134, directly contradicting the pin-rationale comment above it (0.133+ raised MSRV to rustc 1.94.0, not yet stable). Confirmed not an ordeal regression — ordeal 0.17.0 builds cleanly for wasm32-wasip2 standalone.Fix
Re-pin to
^0.132(resolves 0.132.3, the known-good line v1.1.13–v1.1.16 shipped on). Verified locally: cranelift-isle resolves to 0.132.3;loom-shared+loom-islecompile.Unblocks the v1.3.0 release. Durable cure for this recurring class = commit the lockfile (#142).
Refs #142