fix: keep replicate TLS temp files alive - #8013
Open
pablomh wants to merge 1 commit into
Open
Conversation
Replication over HTTPS wrote the CA, client cert, and client key to NamedTemporaryFiles but only kept their paths, so CPython deleted earlier files before pulp-glue could load the upstream API with TLS verification. Keep those files alive for the duration of replicate(), pass the CA bundle path directly as verify_ssl, add regression coverage for the TLS handoff, and clean up the temp files on exit. Assisted-By: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
pablomh
force-pushed
the
fix-replica-tempfile-lifecycle
branch
from
August 26, 2026 10:35
7ef44bc to
6e1bcfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replicate_distributions()task instead of storing only their pathsverify_ssland stop usingPULP_CA_BUNDLEas a process-global side channelverify_sslhandoff, plus a changelog entryTest plan
python3 -m py_compile pulpcore/app/tasks/replica.py pulpcore/tests/unit/test_replica.pyq_select, confirmingreplicate_distributionsandfinalize_replicationcompleteoci-envrequires Docker here)Made with Cursor