Skip to content

[PR #7837/816a6335 backport][3.49] [3.114] Fix RelatedField rendering wrong domain in hrefs #7839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jobselko merged 1 commit into from
Jul 2, 2026
Merged

[PR #7837/816a6335 backport][3.49] [3.114] Fix RelatedField rendering wrong domain in hrefs #7839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/7835.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed `RelatedField` rendering wrong domain in hrefs when `DOMAIN_ENABLED=True`.
10 changes: 10 additions & 0 deletions pulpcore/app/serializers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,16 @@ def _patched_reverse(viewname, args=None, kwargs=None, **extra):
class HrefFieldMixin:
"""A mixin to configure related fields to generate relative hrefs."""

def use_pk_only_optimization(self):
"""Disable DRF's PK-only optimization when domains are enabled.

DRF's optimization passes a PKOnlyObject (no pulp_domain) to get_url,
causing _reverse to fall back to the default domain.
"""
if settings.DOMAIN_ENABLED:
return False
return super().use_pk_only_optimization()

def get_url(self, obj, view_name, request, *args, **kwargs):
# Removes the request from the arguments to display relative hrefs.
self.reverse = _reverse(self.reverse, request, obj)
Expand Down
Loading