Decouple /livez endpoint from the database#7722
Open
dkliban wants to merge 1 commit into
Open
Conversation
dkliban
force-pushed
the
decouple-livez-from-db
branch
from
9fd722d to
17db62d
Compare
gerrod3
requested changes
May 15, 2026
Comment on lines
+1
to
+3
| Decoupled the ``/livez`` liveness probe from the database by skipping | ||
| ``DomainMiddleware``'s ``Domain.objects.get()`` lookup, so the probe returns | ||
| 200 even when the database is unavailable. |
Contributor
There was a problem hiding this comment.
Shorten this to one line and use single tick marks.
DomainMiddleware.process_view() runs Domain.objects.get() on every request, including /livez/. This causes the liveness probe to fail when the database is unavailable, triggering cascading pod restarts. Add a skip_domain_middleware flag to LivezView and honour it in DomainMiddleware so the probe depends only on the gunicorn worker being alive. Fixes pulp#7721 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dkliban
force-pushed
the
decouple-livez-from-db
branch
from
17db62d to
51d503d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip_domain_middleware = Trueflag toLivezViewDomainMiddleware.process_view()to skipDomain.objects.get()when the flag is set/livezprobe now returns 200 even when the database is unavailableOther middleware (
SessionMiddleware,AuthenticationMiddleware) are lazy and don't hit the DB for/livezsinceauthentication_classesandpermission_classesare both empty andrequest.user/request.sessionare never accessed.DomainMiddlewarewas the only eager DB dependency.Fixes #7721
Test plan
/liveztest passes (test_status.py)/livezreturns 200 when database is stopped (manual verification)