Skip to content

fix: switch to instance attributes #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
am9zZWY wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix: switch to instance attributes #2452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/+multiple-registries-auth-state.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed authentication state (bearer token and basic auth) leaking between remotes by storing it per downloader instance instead of on the downloader class.
5 changes: 2 additions & 3 deletions pulp_container/app/downloaders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,13 @@ class RegistryAuthHttpDownloader(HttpDownloader):
Additionally, use custom headers from DeclarativeArtifact.extra_data['headers']
"""

registry_auth = {"bearer": None, "basic": None}
token_lock = asyncio.Lock()

def __init__(self, *args, **kwargs):
"""
Initialize the downloader.
"""
self.remote = kwargs.pop("remote")
self.registry_auth = {"bearer": None, "basic": None}
self.token_lock = asyncio.Lock()

super().__init__(*args, **kwargs)

Expand Down
Loading