ci: Free runner disk space before Docker pull#316
Conversation
phsauter
force-pushed
the
phsauter/ci-fix
branch
4 times, most recently
from
41b72ae to
f2d404a
Compare
phsauter
force-pushed
the
phsauter/ci-fix
branch
from
f2d404a to
7250bc4
Compare
micprog
left a comment
micprog
left a comment
There was a problem hiding this comment.
I remember the oseda container being quite large, which takes a while to properly download, I personally try to stick to default runners unless the larger tools are required, but overall this is still a workable solution. One small item, don't know how you want to handle.
| ./src | ||
| extra_args: "--waiver_files lint/common_cells.style.waiver --rules=-interface-name-style --lint_fatal" | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| reviewdog_reporter: github-check |
There was a problem hiding this comment.
The reviewdog reporting is a nice way to visualize the lint errors in a PR, which I don't think the new solution supports.
colluca
left a comment
colluca
left a comment
There was a problem hiding this comment.
Looks good to me, just have a comment and a question. I don't find the reviewdog reporting particularly useful personally, so from that point of view no difference for me.
There was a problem hiding this comment.
In Snitch I use this https://github.com/jlumbroso/free-disk-space. Might be better than maintaining our own custom action.
| | xargs -0 verible-verilog-lint \ | ||
| --waiver_files lint/common_cells.style.waiver \ | ||
| --rules=-interface-name-style \ | ||
| --lint_fatal=false |
There was a problem hiding this comment.
Why is lint_fatal set to false now?
3 participants
Github runners are not always completely identical, they can vary by disk usage.
This action is copied from the croc repo and fixed a similar out of space issue while the large docker image is downloaded to the runner.
For it to work I had to make the docker container execution explicit instead of using the job-level container invocation since we need to clean before we copy the image, this is again copied from croc.
I also renamed the checks a bit to make them clearer and I have them use the oseda image we need to download anyway instead of downloading more stuff.