support for publish v2 for larger publish payload size#271
Conversation
mohitpubnub
requested review from
Xavrax,
jakub-grzesiowski and
marcin-cebo
as code owners
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…s not needed add headers in case of POST request when header is not for content header, add such header for Http request
jakub-grzesiowski
left a comment
jakub-grzesiowski
left a comment
There was a problem hiding this comment.
One comment, other than that LGTM
| // 155 bytes covers the fixed overhead from base URL components and | ||
| // middleware-injected query params: scheme, origin, path separators, | ||
| // uuid, pnsdk, requestid, instanceid, and timestamp. | ||
| int estimatedSize = 155; |
There was a problem hiding this comment.
is there a chance this could change in the future and should be dynamically calculated instead?
There was a problem hiding this comment.
Due to design of a common API execution flow, In the Endpoint class only that endpoint related path and query segments added. The common query param values are being added in later stage of API execution.
If we try to get all those params here then It would be good amount of code duplication.
Yes, In future, the design can be better to have those values dynamically calculated.
new tests added for message size exceeding 2MiB verification at parameter validation level. increase request timeout default value for non subscribe http request so that history api can have more time to download the content
mohitpubnub
added
status: done
…avoid hard coded magic numbers while calculating the total URL size before making decision on using v2 publish endpoint.
…value, to check format exception isue
… see CI failure is getting fixed or not
|
@pubnub-release-bot release as v8.2.0 |
…ssage with custom type Updated test to use random channel and message names for better uniqueness.
|
🚀 Release successfully completed 🚀 |
4 participants
feat(publishV2): support for the publish v2 endpoint, allowing feature-enabled keysets to publish messages of size up to 2MB.
Added support for the publish v2 endpoint, allowing feature-enabled keysets to publish messages of size up to 2MB.