Skip to content

feat: include every reaction in the vote log #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfabio merged 1 commit into from
Jun 11, 2026
+5 −27
Merged

feat: include every reaction in the vote log #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9618,15 +9618,7 @@ function buildUpdatedComment(body, newLines, newState) {
return `${withoutMarker}\n${newLines.join('\n')}\n\n${stateMarker}`;
}
exports.buildUpdatedComment = buildUpdatedComment;
function steeringCommitteeMembers() {
return __awaiter(this, void 0, void 0, function* () {
return (yield octokit_1.default.teams.listMembersInOrg({
org: 'publiccodeyml',
team_slug: 'steering-committee',
})).data.map(m => m.login);
});
}
function syncIssueVoteLog(owner, repo, issueNumber, members) {
function syncIssueVoteLog(owner, repo, issueNumber) {
var _a;
return __awaiter(this, void 0, void 0, function* () {
const comments = yield octokit_1.default.paginate('GET /repos/:owner/:repo/issues/:issue_number/comments', { owner, repo, issue_number: issueNumber });
Expand All @@ -9643,9 +9635,8 @@ function syncIssueVoteLog(owner, repo, issueNumber, members) {
repo,
comment_id: voteComment.id,
});
const committee = members !== null && members !== void 0 ? members : yield steeringCommitteeMembers();
const liveReactions = reactions.data
.filter(r => { var _a, _b; return (r.content === '+1' || r.content === '-1') && committee.includes((_b = (_a = r.user) === null || _a === void 0 ? void 0 : _a.login) !== null && _b !== void 0 ? _b : ''); })
.filter(r => r.content === '+1' || r.content === '-1')
.map(r => ({
login: r.user.login,
content: r.content,
Expand Down Expand Up @@ -9673,8 +9664,7 @@ function run(owner, repo) {
const issues = yield octokit_1.default.paginate('GET /repos/:owner/:repo/issues', {
owner, repo, state: 'open', labels: 'vote-start',
});
const members = yield steeringCommitteeMembers();
yield Promise.all(issues.map(issue => syncIssueVoteLog(owner, repo, issue.number, members)));
yield Promise.all(issues.map(issue => syncIssueVoteLog(owner, repo, issue.number)));
});
}
exports["default"] = run;
Expand Down
16 changes: 2 additions & 14 deletions src/commands/voteSync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,18 +91,10 @@ export function buildUpdatedComment(
return `${withoutMarker}\n${newLines.join('\n')}\n\n${stateMarker}`;
}

async function steeringCommitteeMembers(): Promise<string[]> {
return (await octokit.teams.listMembersInOrg({
org: 'publiccodeyml',
team_slug: 'steering-committee',
})).data.map(m => m.login);
}

export async function syncIssueVoteLog(
owner: string,
repo: string,
issueNumber: number,
members?: string[],
): Promise<void> {
const comments = await octokit.paginate(
'GET /repos/:owner/:repo/issues/:issue_number/comments',
Expand All @@ -125,10 +117,8 @@ export async function syncIssueVoteLog(
comment_id: voteComment.id,
});

const committee = members ?? await steeringCommitteeMembers();

const liveReactions: LiveReaction[] = reactions.data
.filter(r => (r.content === '+1' || r.content === '-1') && committee.includes(r.user?.login ?? ''))
.filter(r => r.content === '+1' || r.content === '-1')
.map(r => ({
login: r.user!.login,
content: r.content as '+1' | '-1',
Expand Down Expand Up @@ -163,7 +153,5 @@ export default async function run(owner: string, repo: string): Promise<void> {
},
) as Array<{ number: number }>;

const members = await steeringCommitteeMembers();

await Promise.all(issues.map(issue => syncIssueVoteLog(owner, repo, issue.number, members)));
await Promise.all(issues.map(issue => syncIssueVoteLog(owner, repo, issue.number)));
}