Skip to content

Fix config path bug #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bucanero merged 2 commits into from
Jun 25, 2026
Merged

Fix config path bug #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6088f97
Fix paths for config.guess and config.sub
bucanero Jun 24, 2026
4652b4f
Fix paths for config.guess and config.sub
bucanero Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/001-binutils-PPU.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ if [ ! -d ${BINUTILS} ]; then
cat ../patches/${BINUTILS}-PS3.patch | patch -p1 -d ${BINUTILS}

## Replace config.guess and config.sub
cp ../archives/config.guess ../archives/config.sub ${BINUTILS}
cp ../config/config.guess ../config/config.sub ${BINUTILS}

@zeldin zeldin Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. The get-config-scripts.sh script tries to fetch config.guess and config.sub from Savannah and place them in the current working directory. Only if it fails will it copy the files from config to the current working directory. Your change makes this script use the version from config even if a newer version was successfully downloaded from Savannah.

One could argue that the download from Savannah should be removed completely, but performing the download and then not using the result just seems wrong...

@zeldin zeldin Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the disconnect comes from where this was carried over from ps3libraries. In ps3libraries, get-config-scripts.sh downloads (or copies) config.guess and config.sub into archives, where the script can then find them. Here, get-config-scripts.sh instead downloads (or copies) them to the current directory.

@bucanero bucanero Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I see. Sorry for my mistake. I'm going to open a new PR with a proper fix based on your feedback. 👍


fi

Expand Down
2 changes: 1 addition & 1 deletion scripts/005-binutils-SPU.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ if [ ! -d ${BINUTILS} ]; then
cat ../patches/${BINUTILS}-PS3.patch | patch -p1 -d ${BINUTILS}

## Replace config.guess and config.sub
cp ../archives/config.guess ../archives/config.sub ${BINUTILS}
cp ../config/config.guess ../config/config.sub ${BINUTILS}

fi

Expand Down
Loading