Skip to content

libapa only reset __common and after partitions on format for XOSD variant #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uyjulian merged 1 commit into from
Aug 16, 2026
Merged

libapa only reset __common and after partitions on format for XOSD variant #912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions iop/hdd/apa/src/apa-opt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#ifdef APA_XOSD_VER
#define APA_OSD_VER
#define APA_SUPPORT_BHDD
#define APA_FORMAT_WIPE_COMMON_ONLY
#endif

#ifdef APA_OSD_VER
Expand Down
26 changes: 25 additions & 1 deletion iop/hdd/apa/src/hdd_fio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,17 @@ extern apa_device_t hddDevices[];

#ifdef APA_FORMAT_MAKE_PARTITIONS
// TODO: For DVRP firmware 48-bit, __xdata and __xcontents partitions are created
#ifndef APA_FORMAT_WIPE_COMMON_ONLY
static const char *formatPartList[] = {
"__net", "__system", "__sysconf", "__common", NULL};
#endif
#endif

#ifdef APA_FORMAT_WIPE_COMMON_ONLY
#define APA_WIPE_CHUNK_START (8 + 256)
#else
#define APA_WIPE_CHUNK_START 8
#endif

#ifndef APA_8MB_PARTITION_SIZE
#define APA_NUMBER_OF_SIZES 9
Expand Down Expand Up @@ -340,14 +348,17 @@ int hddFormat(iomanX_iop_file_t *f, const char *dev, const char *blockdev, void
// clear apa headers
// TODO: Why does DVRP firmware start clearing at 1024 * 4104 when not 48-bit?
// TODO: DVRP firmware 48-bit clears offset_24+0x2000, offset_24+0x42000, offset_24+0x242000
for (i = 1024 * 8; i < hddDevices[f->unit].totalLBA; i += (1024 * 256)) {
for (i = 1024 * APA_WIPE_CHUNK_START; i < hddDevices[f->unit].totalLBA; i += (1024 * 256)) {
// NOTE: XOSD variant traps on LBA 0 if __mbr detected:
// "hdd: <trap> __mbr will be unformated or destroyed."
blkIoDmaTransfer(f->unit, clink->header, i, sizeof(apa_header_t) / 512,
BLKIO_DIR_WRITE);
}
apaCacheFree(clink);
if ((rv = apaJournalReset(f->unit)) != 0)
return rv;

#ifndef APA_FORMAT_WIPE_COMMON_ONLY
// set up mbr :)
if ((clink = apaCacheGetHeader(f->unit, APA_SECTOR_MBR, APA_IO_MODE_WRITE, &rv))) {
apa_header_t *header = clink->header;
Expand Down Expand Up @@ -393,6 +404,7 @@ int hddFormat(iomanX_iop_file_t *f, const char *dev, const char *blockdev, void
hddDevices[f->unit].status = 0;
hddDevices[f->unit].format = APA_MBR_VERSION;
}
#endif
// TODO: DVRP firmware 48-bit creates __extend partition at offset_24_bit, with same params as __mbr except content is empty
#ifdef APA_FORMAT_MAKE_PARTITIONS
memset(&emptyBlocks, 0, sizeof(emptyBlocks));
Expand All @@ -403,6 +415,17 @@ int hddFormat(iomanX_iop_file_t *f, const char *dev, const char *blockdev, void
// TODO: For DVRP firmware 48-bit, __xdata is created with size 1024 * 2048
// TODO: For DVRP firmware 48-bit, __xcontents is created with size (offset_48_bit - offset_24_bit) - 0x240000 & 0xfffff7ff
// add __net, __system....
#ifdef APA_FORMAT_WIPE_COMMON_ONLY
memset(params.id, 0, sizeof(params.id));
strcpy(params.id, "__sysconf");
if ( !(clink = apaFindPartition(f->unit, params.id, &rv)) )
return rv;
apaCacheFree(clink);
memset(params.id, 0, APA_IDMAX);
strcpy(params.id, "__common");
if ( !hddAddPartitionHere(f->unit, &params, emptyBlocks, clink->sector, &rv) )
return rv;
#else
for (i = 0; formatPartList[i]; i++) {
memset(params.id, 0, APA_IDMAX);
strcpy(params.id, formatPartList[i]);
Expand All @@ -414,6 +437,7 @@ int hddFormat(iomanX_iop_file_t *f, const char *dev, const char *blockdev, void
if (hddDevices[f->unit].partitionMaxSize < params.size)
params.size = hddDevices[f->unit].partitionMaxSize;
}
#endif
#endif
return rv;
}
Expand Down