Add conformance tests for MessageSet duplicates-within-one-entry handling. - #29008
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_955218013
branch
from
August 5, 2026 17:11
c93ea32 to
54bd11a
Compare
…ling. Unlike other cases, MessageSet has the decision that for duplicate ids/payloads is "first wins" (neither last-wins nor merge-semantics like most cases in Protobuf). The special MessageSet wire format encoding was intended to retain compatibility with data written pre-2008 and so has this oddity. PiperOrigin-RevId: 959738838
copybara-service
Bot
force-pushed
the
test_955218013
branch
from
August 5, 2026 17:34
54bd11a to
acaaf91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add conformance tests for MessageSet duplicates-within-one-entry handling.
Unlike other cases, MessageSet has the decision that for duplicate ids/payloads is "first wins" (neither last-wins nor merge-semantics like most cases in Protobuf).
The special MessageSet wire format encoding was intended to retain compatibility with data written pre-2008 and so has this oddity.