fix(procfs): report raw values in parse errors#841
Open
HNO3Miracle wants to merge 1 commit into
Open
Conversation
Use the original string fields when reporting mountinfo and network socket parsing failures. The parsed integer destinations are zero-valued on errors and hide the malformed input. Signed-off-by: HNO3Miracle <xiangao.or@isrc.iscas.ac.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The existing errors format the parsed integer destination, which is zero-valued when parsing fails. This hides the malformed input from callers. Go 1.26.4 also reports these remaining integer arguments as invalid for the %q format verb during downstream package tests.
This follows up on #832, which fixed the same pattern in net_wireless.go, nfs/parse.go, and proc_cgroup.go but did not cover mountinfo.go or net_ip_socket.go.
Testing