config: add reusable exporter config package#3660
Draft
nicolastakashi wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com>
5ca7d6e to
f2787ac
Compare
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This starts a small, incremental refactor to make
node_exportereasier to embed outside the standalone binary.The broader goal is to support ongoing work to make Prometheus exporters embeddable inside the Prometheus OpenTelemetry Collector distribution as native receivers, without requiring each exporter to be rewritten as an OpenTelemetry component.
As a first step, this PR introduces a standalone
configpackage that:ConfigtypeThis does not make
node_exporterfully embeddable yet. It is intended as groundwork for follow-up changes that will extract reusable runtime construction from the CLI layer and gradually reduce process-global configuration wiring.Why
Today, top-level exporter configuration is constructed directly in the binary entrypoint. Moving that configuration shape into a reusable package gives downstream callers and future runtime code a shared place for:
That is a useful first step toward separating: