collector: add nvmesubsystem collector for NVMe-oF path health#3579
Merged
Conversation
742c1b1 to
a0a146e
Compare
Contributor
Author
|
Hi @SuperQ , I created this PR for a new multipath collector. |
a0a146e to
1fa2099
Compare
1fa2099 to
635b613
Compare
3 tasks
jsafrane
reviewed
Mar 13, 2026
There was a problem hiding this comment.
The code looks good to me. I tested it with 2 NVMe over TCP devices, I got:
node_nvmesubsystem_info{iopolicy="numa",model="Linux",nqn="tempdisk",serial="bab529a0f32e397e1319",subsystem="nvme-subsys0"} 1
node_nvmesubsystem_path_state{controller="nvme0",state="connecting",subsystem="nvme-subsys0",transport="tcp"} 0
node_nvmesubsystem_path_state{controller="nvme0",state="dead",subsystem="nvme-subsys0",transport="tcp"} 0
node_nvmesubsystem_path_state{controller="nvme0",state="live",subsystem="nvme-subsys0",transport="tcp"} 1
node_nvmesubsystem_path_state{controller="nvme0",state="resetting",subsystem="nvme-subsys0",transport="tcp"} 0
node_nvmesubsystem_path_state{controller="nvme0",state="unknown",subsystem="nvme-subsys0",transport="tcp"} 0
node_nvmesubsystem_path_state{controller="nvme1",state="connecting",subsystem="nvme-subsys0",transport="tcp"} 0
node_nvmesubsystem_path_state{controller="nvme1",state="dead",subsystem="nvme-subsys0",transport="tcp"} 0
node_nvmesubsystem_path_state{controller="nvme1",state="live",subsystem="nvme-subsys0",transport="tcp"} 1
node_nvmesubsystem_path_state{controller="nvme1",state="resetting",subsystem="nvme-subsys0",transport="tcp"} 0
node_nvmesubsystem_path_state{controller="nvme1",state="unknown",subsystem="nvme-subsys0",transport="tcp"} 0
node_nvmesubsystem_paths_live{subsystem="nvme-subsys0"} 2
node_nvmesubsystem_paths_total{subsystem="nvme-subsys0"} 2
Which looks reasonable.
51fb644 to
8acec17
Compare
3 tasks
17875ea to
d7d2b27
Compare
d7d2b27 to
1a4cac6
Compare
Contributor
Author
|
PR is failing since its based on prometheus/procfs#797, which is still not merged |
04fd251 to
705c86e
Compare
705c86e to
831958f
Compare
831958f to
b614bb3
Compare
b614bb3 to
29a9f17
Compare
Contributor
Author
|
Hi @SuperQ , Please review this PR, Thank you in advance. |
1177a63 to
6bb221b
Compare
jan--f
requested changes
Jul 2, 2026
6bb221b to
c7c93c6
Compare
1046825 to
1d29047
Compare
SuperQ
reviewed
Jul 6, 2026
1d29047 to
26c3987
Compare
26c3987 to
ebf4bd2
Compare
Contributor
Author
ebf4bd2 to
97c3ee9
Compare
Contributor
Author
|
Rebased |
e0b6d5a to
30d6ff4
Compare
jan--f
approved these changes
Jul 6, 2026
Add a new opt-in collector that exposes NVMe-oF subsystem path health via sysfs: - node_nvmesubsystem_info (subsystem metadata) - node_nvmesubsystem_namespace_info - node_nvmesubsystem_path_state (per-state gauge) - node_nvmesubsystem_paths (total controller count) - node_nvmesubsystem_paths_live (live controllers) Controller states are normalised through a single map so adding a new kernel state requires one edit. Signed-off-by: Shirly Radco <sradco@redhat.com> Co-authored-by: AI Assistant <noreply@cursor.com>
30d6ff4 to
bba83bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new disabled-by-default
nvmesubsystemcollector that reads/sys/class/nvme-subsystem/to expose NVMe over Fabrics subsystempath health metrics.
Exposed metrics
The
namespace_infometric enables precise correlation between NVMeblock devices (e.g.
nvme0n1) and their parent subsystems, which isneeded for workload-aware storage path health alerting in Kubernetes
environments.
Enable
No special permissions required — reads only world-readable sysfs attributes.
Dependencies
build(deps): bump prometheus/procfs to v0.21.1)Test plan
testutil.GatherAndComparefor all metricsnormalizeControllerState)