Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
model.Time(-1).Unix()returns0, while the same instant converted withTime().Unix()returns-1. Integer division truncates negative fractional seconds toward zero.Reuse the existing
time.Timeconversion so Unix seconds round down consistently. Tests cover both sides of the epoch, exact seconds, and the earliest/latest representable millisecond timestamps.Validation: the four negative fractional cases fail before the fix.
make testpasses on Go 1.25.13 and 1.26.6, including the full race suite and pinned golangci-lint. License/style and asset checks pass. Both modules declare Go 1.25.0; the shell version-check script requiresreadarray, unavailable in the local macOS Bash.@roidelapluie