add defaultLabels option to metric classes#600
Open
bienzaaron wants to merge 7 commits into
Open
Conversation
|
Instead of applying it during metric usage, maybe it could be added at metric scrape time https://github.com/siimon/prom-client/blob/c1d76c5d497ef803f6bd90c56c713c3fa811c3e0/lib/registry.js#L55-L57 |
Contributor
|
There is default label support in the registry, which you can add each metric to. Given the number of open tickets about memory and CPU pressure, and how much of that is down to the fact of labels, I think it would probably be good to use what is already there instead of adding more ways to do the slow things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a
defaultLabelsoption to the base Metric class and updates each metric class to use the value where appropriate.Closes #598