Retry on conflict when removing owner reference from ClusterConfiguration#1861
Merged
Conversation
…tion Since a ClusterConfiguration is keyed only by cluster (not by profile), every ClusterProfile/Profile matching a given cluster shares the same object. With multiple concurrent reconciles by default, deleting multiple profiles that match the same cluster around the same time causes their reconciler to race on that one object. The second writer to reach the API server got a 409. This PR wraps that in a retry.RetryOnConflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since a ClusterConfiguration is keyed only by cluster (not by profile), every ClusterProfile/Profile matching a given cluster shares the same object. With multiple concurrent reconciles by default, deleting multiple profiles that match the same cluster around the same time causes their reconciler to race on that one object. The second writer to reach the API server got a 409.
This PR wraps that in a retry.RetryOnConflict