CMake: use PROJECT_VERSION for PROJECTM_LIB_VERSION#1009
Open
keeper-of-memes wants to merge 1 commit into
Open
CMake: use PROJECT_VERSION for PROJECTM_LIB_VERSION#1009keeper-of-memes wants to merge 1 commit into
keeper-of-memes wants to merge 1 commit into
Conversation
CMAKE_PROJECT_VERSION refers to the top-level project() call, so when libprojectM is built as a subdirectory of another CMake project (add_subdirectory or FetchContent), PROJECTM_LIB_VERSION picks up the parent project's version instead of projectM's own. PROJECT_VERSION is scoped to the nearest project() call and yields the correct value in both standalone and embedded builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMAKE_PROJECT_VERSIONrefers to the top-levelproject()call, so when libprojectM is built as a subdirectory of another CMake project (add_subdirectoryor FetchContent),PROJECTM_LIB_VERSIONpicks up the parent project's version instead of projectM's own.PROJECT_VERSIONis scoped to the nearestproject()call and yields the correct value in both standalone and embedded builds.One line; no behaviour change for standalone builds.