Audio: use both channels for beat detection (was left-only)#1007
Open
keeper-of-memes wants to merge 1 commit into
Open
Audio: use both channels for beat detection (was left-only)#1007keeper-of-memes wants to merge 1 commit into
keeper-of-memes wants to merge 1 commit into
Conversation
Beat detection (bass/mids/treble) updated only from m_spectrumL; the right-channel spectrum was computed every frame and then discarded, so content weighted to the right channel (or with an L/R imbalance) under-reacted. Average L+R into a mono spectrum and drive the three BeatDetect bands from that. Per-channel render waveforms are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beat detection (bass/mids/treble) updated only from m_spectrumL; the right-channel spectrum was computed every frame and then discarded, so content weighted to the right channel (or with an L/R imbalance) under-reacted. Average L+R into a mono spectrum and drive the three BeatDetect bands from that. Per-channel render waveforms are unchanged.