Skip to content

fix(scale): avoid instance ID precision collisions #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Aug 10, 2026
Merged

fix(scale): avoid instance ID precision collisions #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/cli/src/commands/scale.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ describe('getNextId', () => {
expect(getNextId(instances)).toBe('inst-0100');
});

it('increments ids beyond the safe integer range without collisions', () => {
const instances: FleetEntry[] = [
{ id: 'inst-9007199254740992', provider: 'aws', status: 'running', createdAt: '', hourlyRate: 0.096 },
];
expect(getNextId(instances)).toBe('inst-9007199254740993');
});

it('ignores ids that do not match the inst- pattern', () => {
const instances: FleetEntry[] = [
{ id: 'custom-id', provider: 'aws', status: 'running', createdAt: '', hourlyRate: 0.096 },
Expand Down
6 changes: 3 additions & 3 deletions packages/cli/src/commands/scale.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ export function getNextId(instances: FleetEntry[]): string {
const nums = instances
.map((i) => /^inst-(\d+)$/.exec(i.id)?.[1])
.filter((value): value is string => value !== undefined)
.map((value) => Number.parseInt(value, 10));
const max = nums.length > 0 ? Math.max(...nums) : 0;
return `inst-${String(max + 1).padStart(4, '0')}`;
.map((value) => BigInt(value));
const max = nums.reduce((highest, value) => value > highest ? value : highest, 0n);
return `inst-${String(max + 1n).padStart(4, '0')}`;
}

export function parsePositiveInteger(value: string): number {
Expand Down
Loading