Skip to content

fix(settings): reject malformed retention JSON #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 2 commits into from
Aug 13, 2026
Merged

fix(settings): reject malformed retention JSON #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aba76ea
test(settings): reproduce malformed retention JSON
rissrice2105-agent Aug 13, 2026
2adfc25
fix(settings): reject malformed retention JSON
rissrice2105-agent Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/app/api/settings/disappearing-messages/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,14 @@ export async function PUT(request) {
return NextResponse.json({ error: 'Invalid token' }, { status: 401 });
}

const { default_message_retention_days } = await request.json();
let body;
try {
body = await request.json();
} catch {
return NextResponse.json({ error: 'Invalid JSON body' }, { status: 400 });
}

const { default_message_retention_days } = body;

// Validate input
if (
Expand Down
20 changes: 20 additions & 0 deletions src/app/api/settings/disappearing-messages/route.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,4 +142,24 @@ describe('settings disappearing messages authentication', () => {
expect(mocks.from).not.toHaveBeenCalled();
expect(mocks.updateEq).not.toHaveBeenCalled();
});

it('rejects malformed JSON before updating settings', async () => {
const { PUT } = await import('./route.js');
const malformed = new Request('https://qrypt.chat/api/settings/disappearing-messages', {
method: 'PUT',
headers: {
authorization: 'Bearer valid-token',
'content-type': 'application/json'
},
body: '{"default_message_retention_days":'
});

const response = await PUT(malformed);
const body = await response.json();

expect(response.status).toBe(400);
expect(body.error).toBe('Invalid JSON body');
expect(mocks.from).not.toHaveBeenCalled();
expect(mocks.updateEq).not.toHaveBeenCalled();
});
});
Loading