fix(control): stop a stuck mouse button swallowing every click - #37
Merged
Conversation
A guest could move the pointer but neither side could click anything, and the host stayed locked out until pairux was killed. injectEvent awaited the pending mouse-move batch before handing the button event to the main process. Because those IPC calls run concurrently, a mouseup could overtake the mousedown still waiting behind a slow move batch. The OS then saw a button press with no release and held the virtual button down, so the whole desktop behaved as if it were mid-drag and ate every subsequent click. Serialize all OS injections through a single promise chain so move -> down -> up always reach the backend in the order they arrived. Each operation swallows its own error so later input is never blocked behind a rejected promise. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ThreatCrush Security Scan159 finding(s) HIGH/CRITICAL: 111 | MEDIUM: 48
…and 109 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A guest could move the pointer but neither side could click anything, and the host stayed locked out until pairux was killed.
injectEvent awaited the pending mouse-move batch before handing the button event to the main process. Because those IPC calls run concurrently, a mouseup could overtake the mousedown still waiting behind a slow move batch. The OS then saw a button press with no release and held the virtual button down, so the whole desktop behaved as if it were mid-drag and ate every subsequent click.
Serialize all OS injections through a single promise chain so move -> down -> up always reach the backend in the order they arrived. Each operation swallows its own error so later input is never blocked behind a rejected promise.