Feat/finance finviz fundamentals#114
Merged
Merged
Conversation
Scrape the full Finviz quote-page snapshot (valuation, performance, technical, fund and dividend metrics) plus the company/fund description and render it as a generic Fundamentals grid on /finance/ticker/:ticker. - finviz.ts: getFinvizFundamentals() + testable parseFinvizSnapshot() (linkedom; browser UA since Finviz blocks the default undici UA) - Fundamentals/FundamentalMetric types (ordered label/value/tone pairs, rendered generically so new source rows appear without code changes) - GET /api/finance/fundamentals: paid-gated, soft-fails to null, read-through cached at FUNDAMENTALS_TTL_SECONDS=6h (reuses finance_quotes_cache — no migration) - Stat gains an optional up/down tone prop - Tests: parser + route Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The stream-as-available tests spawn the real ffmpeg binary; on runners
without ffmpeg, spawn('ffmpeg') ENOENT crashes the whole vitest process.
Guard those tests behind a HAS_FFMPEG check instead.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Submission Payout
TDD Checklist (MANDATORY)
All items must be checked before merge:
pnpm test)anytypes used (unless explicitly justified)pnpm tsc --noEmit)pnpm lint)Security Checklist
Testing
Test Coverage
How to Test
Screenshots (if applicable)
Related Issues
Closes #
Additional Notes