fix: resolve SESSION_SECRET lazily to unblock production build#29
Merged
Conversation
PR #20 removed the insecure SESSION_SECRET fallback by throwing at module import when the env var is unset. But `next build` imports API route modules during "Collecting page data", so the top-level throw broke every deploy after #20 (build failed at /api/auth/me with "SESSION_SECRET environment variable is required"). Move the check into a lazy getSessionSecret() called from hmac() at request time. This preserves #20's security intent (no fallback, requests fail if unset) while letting the build import route modules cleanly. Verified: `next build` now succeeds with SESSION_SECRET unset. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every Railway deploy since #20 (remove hardcoded session secret fallback) has failed to build. The last successful deploy was #24; #20 and everything after fails at:
SESSION_SECRETis set on the Railway service, but #20 throws at module import time, andnext buildimports API route modules during "Collecting page data" — so the top-level throw aborts the build.Fix
Move the check into a lazy
getSessionSecret()invoked fromhmac()at request time. This preserves #20's security intent (no insecure fallback; requests still fail if the secret is unset) while letting the build import route modules cleanly.Verification
next buildnow succeeds locally withSESSION_SECRETunset (reproducing the build env). Previously this threw; now the full route manifest builds.🤖 Generated with Claude Code