Fix p5.Image copy method to mark image as modified#8846
Closed
Chessing234 wants to merge 2 commits into
Closed
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Copying pixels into a p5.Image using the
copy()method does not mark the image as modified. This causes issues when using the image as a WEBGL texture immediately after, as the new pixels are not uploaded to the GPU.Root Cause: The
copy()method inp5.Imagedelegates top5.prototype.copybut fails to callthis.setModified(true)on itself afterward.Why fix is correct: Adding
this.setModified(true)explicitly marks the image as modified so downstream consumers (like WEBGL textures) know to update their data from the image.