fix(color): prevent NaN saturation in HSLA to HSBA at zero lightness#8845
Closed
Chessing234 wants to merge 1 commit into
Closed
fix(color): prevent NaN saturation in HSLA to HSBA at zero lightness#8845Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
color.toString('hsb')returns NaN saturation for HSL black (color(0, 100, 0)in HSL mode).Root cause
_hslaToHSBAdivides byvalwhen computing saturation. For zero lightness,valis 0, producing0/0.Why this fix is correct
Return saturation 0 when
val === 0, matching how_hsbaToHSLAalready guards theli === 1case.Resolves N/A (discovered during color conversion review; no open issue).
PR Checklist
npm run lintpassesMade with Cursor