Conversation
coseeian
marked this pull request as ready for review
September 14, 2026 12:58
coseeian
added
the
Accessibility: Best Practice
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stops a11y page tests from reporting duplicate
landmark-uniqueviolations inside sketch preview frames.axe automatically merges same-origin iframe DOMs into the main page's test suite. And p5 SDK generates sketch contents at runtime, creating an unnamed
<main>for every canvas. So any page with an embedded sketch triggers duplicate landmark violations against the page's own<main>region.We can't fix this at the site level. The
<main>landmark structure in sketch frames comes from runtime of p5 SDK.So this PR uses the target frame selector
["iframe", "body"]to ignore the inner frame contents, while continuing to test the<iframe>element itself for accessibility attributes like title. Nothing site-authored is skipped.